Skip to content

fix: correct query result memory estimate#287

Draft
chrispader wants to merge 2 commits into
mainfrom
codex/fix-query-result-memory-estimate
Draft

fix: correct query result memory estimate#287
chrispader wants to merge 2 commits into
mainfrom
codex/fix-query-result-memory-estimate

Conversation

@chrispader

@chrispader chrispader commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary

  • correct unordered_map row node memory accounting to add per-node padding instead of multiplying by it
  • include row key strings, large text values, owning blob buffers, and metadata map storage in query result external-memory pressure
  • move query result containers into the HybridObject to avoid extra peak memory copies
  • avoid building full query result objects during batch execution when only rowsAffected is needed

Validation

  • nr lint-cpp
  • nr sqlite typecheck
  • git diff --check

Fixes the issue reported in #261 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant