implemented special characters L,W,# - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README has always listed L, W and # as supported; the parser never understood any of them. This implements all three.
Wnever crosses into another month, and L alone in the day-of-week field means Saturday, both as in Quartz. Each qualifier applies to a single value, so5#2,6#3is rejected. They remain invalid in the other fields.cronexprnow carries two option structs beside the bitsets, since the day these select depends on the month; the existing day-by-day scan consults them.Testing
Lalso uncovered an unrelated bug:0 30 23 L 2 ?skipped 2012 entirely, because setting the month while the day was still 31 rolled February over into March. Fixed here too, same family as #30.New
test_special.cppcovers all three, with dates worked out from the calendar rather than read back from croncpp.Fixes #18 and #14. Also delivers what #36 asked for, which was closed earlier by rejecting these characters instead of implementing them.