complete the chrono overloads - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
std::chronooverloads added in #39 turned a failed lookup into a real-looking timestamp.cron_nextreturnsINVALID_TIMEwhen an expression has no next occurrence - an expression whose years have all gone by, say - and the chrono wrapper passed that straight tofrom_time_t, yielding1969-12-31 23:59:59. A caller had no way to tell that from a genuine answer.They now return
time_point::min(), matching how the other overloads already report it:Both overloads are also templated on the duration now, so a caller working in milliseconds gets milliseconds back instead of the clock's default duration. Explicit traits still work, since
Durationis deduced.croncpp stays within C++11, so none of C++20's calendar or time zone facilities are used.
New
test_chrono.cppcovering the three overloads agreeing on the same instant, the failure sentinel, duration round-tripping checked withstatic_assert, sub-secondcron_next_ceil, and explicit traits.Fixes #10.