Skip to content

set build_flags: [-v, -i] if empty for compatibility, small updates to doc#17

Open
flibustenet wants to merge 1 commit into
markbates:masterfrom
flibustenet:BuildFlags
Open

set build_flags: [-v, -i] if empty for compatibility, small updates to doc#17
flibustenet wants to merge 1 commit into
markbates:masterfrom
flibustenet:BuildFlags

Conversation

@flibustenet

Copy link
Copy Markdown
Contributor

I didn't know how to differentiate between empty build_flags:[] and not set at all.
I updated the refresh.yml of the readme with the current init.

@opalfroot

opalfroot commented Jul 2, 2017

Copy link
Copy Markdown
Contributor

I think the difficulty with this is that you're trying to proxy configuration options through YML then applying defaults which feels like we're overriding configurable behaviour.

The build flags could be set via composition within the main config and have a validation function to determine if the user specific config is runnable. This would be quick and easy and a better alternative to overriding user configuration.

Alternatively a validation function on the main config might be just as simple

@flibustenet

Copy link
Copy Markdown
Contributor Author

I'm not sure to see what you mean, i prefer to let you do it if you can

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants