set build_flags: [-v, -i] if empty for compatibility, small updates to doc#17
Open
flibustenet wants to merge 1 commit into
Open
set build_flags: [-v, -i] if empty for compatibility, small updates to doc#17flibustenet wants to merge 1 commit into
flibustenet wants to merge 1 commit into
Conversation
Contributor
|
I think the difficulty with this is that you're trying to proxy configuration options through YML then applying defaults which feels like we're overriding configurable behaviour. The build flags could be set via composition within the main config and have a validation function to determine if the user specific config is runnable. This would be quick and easy and a better alternative to overriding user configuration. Alternatively a validation function on the main config might be just as simple |
Contributor
Author
|
I'm not sure to see what you mean, i prefer to let you do it if you can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't know how to differentiate between empty
build_flags:[]and not set at all.I updated the refresh.yml of the readme with the current init.