Skip to content

MLE-30244 move Jenkins registry credentials to the publish stage and …#1951

Merged
RitaChen609 merged 4 commits into
developfrom
MLE-30244-scope-Jenkins-registry-credentials-to-publish-stage
Jun 26, 2026
Merged

MLE-30244 move Jenkins registry credentials to the publish stage and …#1951
RitaChen609 merged 4 commits into
developfrom
MLE-30244-scope-Jenkins-registry-credentials-to-publish-stage

Conversation

@RitaChen609

Copy link
Copy Markdown

…validate the MARKLOGIC_IMAGE_TAGS build parameter

…validate the MARKLOGIC_IMAGE_TAGS build parameter
Copilot AI review requested due to automatic review settings June 24, 2026 17:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Jenkins pipeline for the MarkLogic Java client API build to (a) scope publishing credentials to the publish stage instead of global environment variables and (b) validate the MARKLOGIC_IMAGE_TAGS parameter to reduce the risk of user-supplied tag values altering shell/Docker command behavior.

Changes:

  • Moved registry/publish credentials from global environment {} to a withCredentials block in the publish stage.
  • Added validation for MARKLOGIC_IMAGE_TAGS before using it to construct Docker image references in the regressions stage.

Comment thread Jenkinsfile Outdated
Comment thread Jenkinsfile Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread Jenkinsfile Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread Jenkinsfile Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

Jenkinsfile:245

  • imageTags is already trimmed via .collect { it.trim() }, but the loop trims each tag again. This is redundant and slightly obscures the intent; use the already-trimmed tag directly (or trim once per iteration, but not both).
					imageTags.each { tag ->
						def fullImage = imagePrefix + tag.trim()
						def stageName = "regressions-${tag.trim().replace(':', '-')}"

@RitaChen609 RitaChen609 merged commit 9242bc7 into develop Jun 26, 2026
4 of 5 checks passed
@RitaChen609 RitaChen609 deleted the MLE-30244-scope-Jenkins-registry-credentials-to-publish-stage branch June 26, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants