Conversation
test/run-tests-podman.sh shims docker -> podman and delegates to run-tests.sh, working around several podman-compose (1.6.0) quirks (broken !override variable interpolation, --wait hanging on one-shot containers, hyphen vs underscore container naming). Also fixes issues that affect podman regardless of the wrapper: - add :z SELinux relabeling to read-only bind mounts so rootless podman on enforcing SELinux hosts can read them - fmsg-webapi now creates/chowns /opt/fmsg/data like fmsgd, closing a race where whichever container touches the shared named volume first seeds its ownership - simplify the test compose override's depends_on to short form and drop the certbot profile gate, which podman-compose can't parse/ resolve correctly
Collapsing fmsgd/fmsg-webapi depends_on to short-list form dropped the postgres service_healthy condition, letting fmsgd race postgres on startup under Docker Compose. Restore the long form with conditions in the shared compose file, and have the podman shim flatten it back to a short list (preserving the !override tag, which the previous flattening dropped and which let podman-compose merge in a stale certbot dependency, causing an intermittent "container state improper" failure on the second stack).
The podman commit dropped `profiles: ["certbot"]` from the stubbed certbot service to work around a podman-compose parse issue. Without the profile gate, `docker compose up` starts certbot by default, and since its stub entrypoint exits immediately by design, `--wait` treats that expected exit as an unexpected failure and aborts the whole stack start-up. Restore the profile gate for Docker Compose and have the podman shim strip it, since podman-compose can't parse it and doesn't need it (the shim already drops --wait entirely).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/run-tests-podman.sh shims docker -> podman and delegates to run-tests.sh, working around several podman-compose (1.6.0) quirks (broken !override variable interpolation, --wait hanging on one-shot containers, hyphen vs underscore container naming).
Also fixes issues that affect podman regardless of the wrapper: