chore(Routes.Route): remove param override#3341
Merged
Merged
Conversation
This used the `Phoenix.Param` [protocol](https://phoenix.hexdocs.pm/Phoenix.Param.html) to convert the Route struct into URL parameters, but I don't think we wish to convert all Green Line branch links to direct to the combined Green Line page anymore.
joshlarson
approved these changes
Jul 17, 2026
joshlarson
left a comment
joshlarson
left a comment
Contributor
There was a problem hiding this comment.
Nice catch - this feels like one of those things that could easily have driven someone (me) up a tree, trying to figure out why ~p"/schedules/#{%Route{id: "Green-E"}}" was returning /schedules/Green... I wouldn't even have known to look here!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket: 🐞 GL search results aren't working for branches
Implementation
We used the
Phoenix.Paramprotocol to convert the Route struct into URL parameters, but I don't think we wish to convert all Green Line branch links to direct to the combined Green Line page anymore.So I deleted this.
How to test
Util.site_path(:schedule_path, [:show, Routes.Repo.get("Green-B")])outputs"/schedules/Green-B"instead of"/schedules/Green"