fix(xlings): the remedy for a SubOS with no subos_info is a command that works - #447
Merged
Merged
Conversation
…hat works
Three messages told the user how to get an undescribed SubOS described, and
all three named something that does not do it. The wording has now been wrong
in two opposite directions:
1. `xlings self update` — which does not touch a subos manifest at all.
2. "an existing one is NOT backfilled; recreate the SubOS" — the correction
to (1), and also wrong. `xlings self doctor --fix` has always described
the ACTIVE subos; what it got wrong was the CONTENT, stamping the block
with whatever the built-in default libc happened to be rather than with
what the SubOS actually runs.
xlings 2026.8.17.1 fixes the content (openxlings/xlings#547): the runtime now
comes from the recorded binding, the workspace record, or the payload behind
`lib/libc.so.6` — and when none of those can answer, the `runtime` key is
OMITTED rather than filled with a guess.
That last part lands on a path this file already had: `info.present &&
info.runtime.empty()` already notes that runtime rules cannot be evaluated.
It was written for a hypothetical and is now the honest state a described-but-
unprovable SubOS reports, so nothing here needs to change to accept it.
"from inside this SubOS" is load bearing: doctor inspects the subos the run is
in and no other. When mcpp is the one complaining, the user is in it.
Telling someone to delete and recreate a SubOS to recover an environment is a
large ask, and it was never the smallest one that works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three messages tell the user how to get an undescribed SubOS described, and all three name something that does not do it. The wording has now been wrong in two opposite directions:
xlings self update— which does not touch a subos manifest at all.xlings self doctor --fixhas always described the ACTIVE subos. What it got wrong was the content: it stamped the block with whatever the built-in default libc happened to be, rather than with what the SubOS actually runs. On a measured 39-subos home that produced two subos declaringglibc@2.44over a sysroot serving 2.39.openxlings/xlings#553 (xlings 2026.8.17.1) fixes the content: the runtime comes from the recorded binding, the workspace record, or the payload behind
lib/libc.so.6— and when none of those can answer, theruntimekey is omitted rather than filled with a guess.No ordering constraint
self doctor --fixsupplies the block on today's xlings too, so this message is true before that release lands; it just writes a runtime that may be wrong. The parenthetical says which version records it truthfully so the user can tell the two apart.The omitted-runtime state already has a home here
runtime_binding.cppmalready handlesinfo.present && info.runtime.empty():That was written for a hypothetical. It is now the honest state a described-but-unprovable SubOS reports, so nothing here needs to change to accept the new format — which is worth stating explicitly, since the alternative reading is that it was untested and happens to work.
Why the wording matters more than usual
"from inside this SubOS" is load bearing: doctor inspects the subos the run is in and no other. When mcpp is the one complaining, the user is in it.
And telling someone to delete and recreate a SubOS to recover an environment is a large ask — it was never the smallest thing that works.
Sites changed:
platform/xlings/subos_info.cppm,platform/runtime_binding.cppm,toolchain/lifecycle.cppm.