feat(order): add currency, integration_data, prev_transaction_ref and transaction_security to request classes - #386
Open
Diego Barajas (barajas-d) wants to merge 9 commits into
Open
Conversation
…prev_transaction_ref, transaction_security) Additive changes to Order request classes (Lombok @builder, no breaking change): - OrderCreateRequest: adds currency (String) and integrationData - OrderIntegrationDataRequest + OrderSponsorRequest: new (integrator_id, platform_id, corporation_id, sponsor.id) - OrderStoredCredentialRequest: adds prevTransactionRef (String) - OrderTransactionSecurityRequest: new (validation, liability_shift) - OrderOnlineConfig: links transactionSecurity (nested under config.online, per canonical reference) All fields optional; existing builders unaffected (backward compatible). JSON keys are snake_case via Gson LOWER_CASE_WITH_UNDERSCORES policy. Closes: orders-sdk-typed-request-classes Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
OrderOnlineConfig.transactionSecurity was updated to use the master type (OrderTransactionSecurity) during rebase conflict resolution. The test still referenced the feature-branch type (OrderTransactionSecurityRequest). Both classes have identical fields; align the test with the main code. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…ountry to AddressRequest - AddressRequest: add country field (required by Orders API) - OrderPayerRequest: replace resources/common/Identification and Phone with client/common/IdentificationRequest and PhoneRequest; replace OrderPayerAddressRequest with client/common/AddressRequest - Delete OrderPayerAddressRequest (no remaining consumers) - Update CreateOrderCheckoutPro example and OrderClientCheckoutProTest to use AddressRequest.builder() - Add OrderPayerRequestSerializationTest (5 tests, 0 failures) JSON output is byte-identical for existing fields; country is a new optional key omitted when null. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Code review (0 issues, 14 rules) and security review (0 vulnerabilities) both passed. All 5 tasks completed. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Adds CreateOrderWithAutomaticPayments.java showing the complete AP flow: first payment (first_payment: true) and recurring MIT charge (first_payment: false + prevTransactionRef), following the same style and level of detail as existing order examples. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
…ence in stored_credential
Diego Barajas (barajas-d)
force-pushed
the
feature/order-fields-sdk
branch
from
August 3, 2026 20:41
d280545 to
6601035
Compare
luismeli10 (luismeli10)
previously approved these changes
Aug 3, 2026
Move local SDD specs/tasks to external directory outside the repo. Add meli/ to .gitignore to prevent accidental re-inclusion. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Revert cosmetic reorder introduced in previous commit — field declaration order has no functional effect and only adds noise to the diff. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
luismeli10 (luismeli10)
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Agrega 4 campos faltantes a las clases Request del Orders API de forma aditiva vía
@Builder. Sin ruptura de compatibilidad.Campos agregados (9)
OrderCreateRequestcurrencyString, nullableOrderCreateRequestintegrationDataOrderIntegrationDataRequestOrderStoredCredentialRequestprevTransactionRefintegration_dataintegratorId,platformId,corporationId,sponsor.idOrderOnlineConfigtransactionSecurityOrderTransactionSecurity— 3DSNuevas clases
OrderIntegrationDataRequest,OrderSponsorRequest,OrderTransactionSecurityRequestCompatibilidad
Todos los campos sin
@NonNull, defaultnull. Builders existentes sin los nuevos campos continúan funcionando.