Skip to content

thinknode_m1: stop GPS code from driving the LoRa radio power pin #2865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benskigomez wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

thinknode_m1: stop GPS code from driving the LoRa radio power pin #2865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion variants/thinknode_m1/variant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,12 @@ extern const int SCK;
#define PIN_GPS_RX (40)
#define PIN_GPS_TX (41)
#define GPS_EN (34)
#define PIN_GPS_RESET (37)
// NOTE: pin 37 is the LoRa radio power enable (SX126X_POWER_EN), NOT a GPS reset.
// It must not be defined as PIN_GPS_RESET: the location provider drives the GPS
// reset pin in begin()/stop(), so doing so would toggle the radio's power -- in
// particular, turning GPS off would cut power to the LoRa radio. The M1 GPS has
// no MCU-controlled reset line, so tell the provider there is none.
#define GPS_RESET (-1)
#define PIN_GPS_PPS (36)
#define PIN_GPS_STANDBY (34)
#define PIN_GPS_SWITCH (33)