Decode timestamp batches without frame index conversion - #1629
Draft
mavenlin wants to merge 5 commits into
Draft
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1629
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mavenlin
force-pushed
the
agent/vfr-timestamp-batches-review
branch
5 times, most recently
from
August 14, 2026 08:27
9199278 to
38d9948
Compare
mavenlin
marked this pull request as ready for review
August 14, 2026 08:31
mavenlin
marked this pull request as draft
August 14, 2026 08:56
mavenlin
force-pushed
the
agent/vfr-timestamp-batches-review
branch
from
August 14, 2026 09:10
38d9948 to
a581f06
Compare
Contributor
Author
|
Sharing some tests, I compare the Tested on a sampled set of videos from diverse sources. The 4/5 columns reports the number of frames that differs from the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_frames_played_atcurrently converts timestamps to indices before decoding. That assumes a single global timestamp-to-index mapping, which is not valid for VFR video. The singularget_frame_played_atalready seeks and decodes by requested timestamp; batch lookup should match it.