materialize raw frame tests - #1630
Merged
Merged
Conversation
The materialize() tests only checked that pix_fmt was a non-empty string. Assert the exact format we expect on each device instead, and derive the expected plane dtype from it rather than sniffing digits out of the name. Adds two tests: - CUDA and CPU raw planes must be bit-identical (skipped for the sources NVDEC currently hands us as 8-bit nv12). - The ColorConverter must map the limited-range black and white points, expressed in the frame's own sample scale, to 0 and 255 - which pins its notion of how many bits a sample carries.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1630
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add more tests for the pixel format handling of blocks APIs. Still a bit wonky because the CUDA path doesn't handle HDR yet. Will be cleaned up by #1625