F182 packs: Spanish + Tagalog UI-language packs (subset, machine-drafted) — stacked on #233#234
Merged
Conversation
added 3 commits
July 26, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Spanish (
es) + Tagalog (tl) UI-language packs and turns the language selector on (Account → Preferences now offers English / Español / Tagalog).Scope — subset, honest
Only the already-externalized surface is translated: login, sales, Account → Preferences, and validation error messages. Every other screen (and the rest of the Account screen, e.g. the password section) still renders in English — the full string sweep of the ~18 remaining screens is tracked in #182. So a Spanish/Tagalog user sees those 4 areas localized and the rest in English (English is the fallback for every not-yet-translated string).
What this adds
web/src/i18n/es.ts,web/src/i18n/tl.ts— mirroren.ts's 104 keys exactly (en.tsstays the typed source of truth). Header notes mark them machine-drafted + list the intentional loanwords.web/src/i18n/index.ts—SUPPORTED_LANGUAGES = ["en","es","tl"]; exports a singleRESOURCES = { en, es, tl }used by bothinitand the parity test.LanguageSelector— display names (English / Español / Tagalog); the selector now renders (it was hidden while English-only).catalogParity.test.ts— asserts each pack has exactly en's key set (a missing key = silent English fallback → test fails) and the same{{placeholder}}+ tag structure per value (so a future edit can't drop{{ref}}or break the<Trans>markup undetected). Self-registering offRESOURCES.CONTRIBUTING-i18n.md"adding a pack" steps; HelpPage prose + a "UI language" in-app glossary entry;GLOSSARY.mdupdated.Native review
I generated these; they need a native speaker before real users see them. Structurally verified (parity + placeholders intact, no leftover English in translated slots after the fix wave), but flag for review:
unitFlat= "Cubeta" (regional — cubeta/maple/panel); a few mildly stilted phrasings.methodCheck= "Tseke" (vs "Cheke");atMostDecimalshas no plural form (pre-existing i18n limitation).Review
4-way per policy — codex + two Claude agents + pi. All confirmed the packs are structurally sound (en.ts unchanged, parity real, placeholders intact, no locked coverage threshold touched, tests strengthened not weakened) with no Critical/Important code defect. Their findings were folded in a fix wave: the parity test now guards placeholders/tags + is self-registering; the 4 accidental-looking Tagalog leftovers were resolved (
customer→ "Kustomer"; the loanwords documented as intentional); the in-app glossary entry added; the "Account screen translated" wording narrowed to "Account → Preferences." A scoped re-review confirmed all fixes (including a mutation test proving the parity guard catches a dropped placeholder).Testing
npm run test:coverage651 tests green; coverage above the (unchanged) floors;npm run typecheckclean;npm run buildsucceeds. New tests: catalog parity (keys + placeholders + tags), es/tl language resolution, the now-visible 3-language selector.