Skip to content

Update PROTOCOL-PDO.md - #22

Closed
hsmade wants to merge 1 commit into
michaelarnauts:masterfrom
hsmade:patch-1
Closed

Update PROTOCOL-PDO.md#22
hsmade wants to merge 1 commit into
michaelarnauts:masterfrom
hsmade:patch-1

Conversation

@hsmade

@hsmade hsmade commented Mar 23, 2024

Copy link
Copy Markdown
Contributor

-1 doesn't exist in UINT, so I converted them to what the value would be in the respective UINTs

-1 doesn't exist in UINT, so I converted them to what the value would be in the respective UINTs
@denmaus

denmaus commented Mar 23, 2024

Copy link
Copy Markdown

I must admit that at least 4294967295 looks like a magic number.
Is not possible to use a more intuitive and clear syntax: 0xFF for 8 bit and 0xFFFF for 16 bit numbers?

@michaelarnauts

Copy link
Copy Markdown
Owner

I agree with @denmaus, while you are technically correct that it's impossible to specify a negative number with an unsigned int, it does make it more clear what the values mean by just indicating a negative number.

I prefer this clarity. Maybe a note below the table to indicate this might be better?

@hsmade

hsmade commented Mar 29, 2024

Copy link
Copy Markdown
Contributor Author

Maybe: -1 (0xFFFF) ?

@michaelarnauts

Copy link
Copy Markdown
Owner

Maybe: -1 (0xFFFF) ?

That's also fine I guess :)

Copy link
Copy Markdown
Owner

Thanks for this. Closing it out, for two reasons:

  • The diff is based on an older version of PROTOCOL-PDO.md (it predates the 6=boost value that's since been added) and now conflicts with the current operating-mode row.
  • The change is really a signed-vs-unsigned representation choice (-1 vs 255 for the same byte). I'm keeping the signed convention (-1=auto, etc.) for consistency across the doc.

Appreciate the contribution regardless — thanks!


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants