chore: modernize development infrastructure and build configuration - #63
Closed
sfo2001 wants to merge 3 commits into
Closed
chore: modernize development infrastructure and build configuration#63sfo2001 wants to merge 3 commits into
sfo2001 wants to merge 3 commits into
Conversation
sfo2001
commented
Jun 23, 2025
sfo2001
commented
- Add PEP 621 [project] section to pyproject.toml for dual Poetry/standard packaging support
- Enhance CI/CD workflow with improved Python 3.10-3.13 testing matrix and caching
- Add comprehensive development tooling: pytest-asyncio, pytest-cov, mypy, pylint-protobuf
- Improve pylint configuration with protobuf support and better rule management
- Add pytest configuration with asyncio mode and coverage reporting
- Update Makefile with coverage reporting and enhanced pylint integration
The discovery process failed due to the default Python broadcast address not working in all cases, causing UDP packets to not leave the interface and resulting in no units being found in the local network. This fix ensures the correct broadcast address is used.
…ast-new fix(discovery): resolve Windows broadcast discovery failure with ProactorEventLoop
sfo2001
force-pushed
the
upstream/pr3-modernize-infrastructure
branch
3 times, most recently
from
June 23, 2025 20:58
a456acf to
4f15e93
Compare
This commit modernizes the project's development infrastructure while maintaining backward compatibility. Rebased on top of PR1 (netifaces dependency fix). Key improvements: - Add PEP 621 [project] section to pyproject.toml for dual Poetry/standard packaging support - Enhance CI/CD workflow with improved Python 3.10-3.13 testing matrix and caching - Make tests optional in CI when tests directory doesn't exist (tests added in future PR) - Add comprehensive development tooling: pytest-asyncio, pytest-cov, mypy, pylint-protobuf - Improve pylint configuration with protobuf support and netifaces C extension handling - Add pytest configuration with asyncio mode and coverage reporting - Update Makefile with coverage reporting and enhanced pylint integration - Fix code quality issues: specific exception handling and black formatting - Update poetry.lock to include all dependencies (netifaces + new dev tools) All quality checks pass with 10.00/10 pylint score and proper black formatting. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
sfo2001
force-pushed
the
upstream/pr3-modernize-infrastructure
branch
from
June 23, 2025 21:06
4f15e93 to
1bee1dc
Compare
Owner
|
Thanks for the effort here — some of this (CI/packaging modernization) is genuinely useful. I'm closing it because it bundles too many unrelated changes, and a few of them I can't take as-is:
If you'd like to resubmit, please split it up: a focused CI/packaging PR is welcome on its own, kept separate from any source or dependency changes. Thanks for understanding. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.