Skip to content

Support esp-idf v6.0#334

Draft
Narukara wants to merge 1 commit into
rollingfrom
support-esp-idf-v6.0
Draft

Support esp-idf v6.0#334
Narukara wants to merge 1 commit into
rollingfrom
support-esp-idf-v6.0

Conversation

@Narukara

@Narukara Narukara commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Depends on #325, #324, #323, #329

WIP

@Narukara Narukara force-pushed the support-esp-idf-v6.0 branch from c34c11b to 5641bd9 Compare May 8, 2026 06:29
@Narukara Narukara force-pushed the support-esp-idf-v6.0 branch from 5641bd9 to acda650 Compare May 19, 2026 02:44
@mergify

mergify Bot commented May 27, 2026

Copy link
Copy Markdown
Contributor

This pull request is in conflict. Could you fix it @Narukara?

@Narukara Narukara force-pushed the support-esp-idf-v6.0 branch from acda650 to 07b3f3f Compare May 27, 2026 07:01
@Narukara Narukara force-pushed the support-esp-idf-v6.0 branch 2 times, most recently from ecd3823 to e811475 Compare June 23, 2026 09:12
@Narukara Narukara force-pushed the support-esp-idf-v6.0 branch from e811475 to 7f6db2c Compare June 24, 2026 07:38
Comment thread esp32_toolchain.cmake.in

add_compile_definitions(ESP_PLATFORM LWIP_IPV4 LWIP_IPV6 PLATFORM_NAME_FREERTOS)
# Keep `__STDC_WANT_LIB_EXT1__=1` until micro-ROS/rcutils includes ros2/rcutils#555.
add_compile_definitions(ESP_PLATFORM LWIP_IPV4 LWIP_IPV6 PLATFORM_NAME_FREERTOS __STDC_WANT_LIB_EXT1__=1)

@Lapshin Lapshin Jun 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that __STDC_WANT_LIB_EXT1__ is implemented only for picolibc

@Lapshin

Lapshin commented Jun 29, 2026

Copy link
Copy Markdown

Not related to this MR:

Declaring this project as an IDF component while also having an esp32_toolchain.cmake.in file to build a static library seems odd to me.

With this approach, you can lose the required compile options and break the ABI when linking the final ELF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants