WIP: classroom motivated changes - #30
Draft
microbit-matt-hillsdon wants to merge 2 commits into
Draft
Conversation
python-editor's Chakra theme shrank the numeric spacing/sizes grid to Chakra's × 0.88 and fontSizes md+ to × 0.9 (the 2022 "make everything smaller" change), and its migration replicated that in its app preset. classroom's theme turns out to carry the identical scale — byte-identical values, same change — so it belongs in one shared place rather than in two app presets. New optional `@microbit/ui/dense-preset`, stacked between the base preset and the app preset by the two dense apps. ml-trainer and data-microbit-org don't use it. Whether the family keeps this density or aligns on one scale is still open; this is now the single place that answer lands. See migration-playbook gotcha #25, which is what makes a global scale override worth being explicit and shared about.
The family splits 2–2 on button colour idiom: brand-coloured buttons (ml-trainer, python-editor) and a black-on-white system (classroom, data-microbit-org — black solid, black outline, and a blackAlpha wash on hover/press instead of a border-colour change). Without tokens, both apps on the second side fork the `primary`/`secondary` variants in their own presets: the same divergence, written twice. So the two variants now resolve their colours through `button.*` semantic tokens, defaulting to today's brand values — resolved output is unchanged for the two migrated apps (verified: the recipe rules differ only by var indirection). classroom overrides nine values. `primary`'s text stays a literal `white` and `ghost` needs no tokens: both are the same in all four apps. Also refreshes the playbook's v1-surface list, which had drifted from what's actually built, and records the decision against a shared Table component (python-editor's one table site is a styled.table, which reads better than a slot recipe over native table semantics).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.