Take over react-aria's prop-replaceable strings via our catalogs - #53
Merged
Conversation
Deploying ui with
|
| Latest commit: |
3af6ab9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://93584e51.ui-2wg.pages.dev |
| Branch Preview URL: | https://rac-strings-via-catalogs.ui-2wg.pages.dev |
Where react-aria lets a prop replace one of its built-in strings — NumberField's stepper labels, the toast region's landmark label, ComboBox's trigger and listbox labels, Select's placeholder and the GridList row-selection checkbox name — the components now pass our own react-intl messages, so the strings ride lang/ and Crowdin like everything else and ca/cy/ga-IE (which react-aria lacks) can catch up. Translations are pre-seeded from react-aria's own catalogs (adobe/react-spectrum at react-aria-components@1.19.0, Apache 2.0 — notice in LICENSE.md, provenance in the README's Strings section since Crowdin roundtrips rewrite the lang JSON). ca/cy/ga-IE/lol carry the English backfill until translated in Crowdin. SharedUIProvider's locale-plumbing tests probed react-aria's resolved locale via NumberField's steppers, which are now ours; they probe the Modal's hidden dismiss button instead. Fixes #48
microbit-matt-hillsdon
force-pushed
the
rac-strings-via-catalogs
branch
from
August 7, 2026 13:58
47fa4b2 to
3af6ab9
Compare
Contributor
Author
|
We'll need to do a Crowdin dance here because we have some English that we don't want to replace with these translations. Either we pre-translate it and upload these or we hope it gets translated via duplicates (quite likely)... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where react-aria lets a prop replace one of its built-in strings — NumberField's stepper labels, the toast region's landmark label, ComboBox's trigger and listbox labels, Select's placeholder and the GridList row-selection checkbox name — the components now pass our own react-intl messages, so the strings ride lang/ and Crowdin like everything else and ca/cy/ga-IE (which react-aria lacks) can catch up.
Translations are pre-seeded from react-aria's own catalogs (adobe/react-spectrum at react-aria-components@1.19.0, Apache 2.0 — notice in LICENSE.md, provenance in the README's Strings section since Crowdin roundtrips rewrite the lang JSON). ca/cy/ga-IE/lol carry the English backfill until translated in Crowdin.
SharedUIProvider's locale-plumbing tests probed react-aria's resolved locale via NumberField's steppers, which are now ours; they probe the Modal's hidden dismiss button instead.
Fixes #48