Test Result Analyzer fails if no stack trace is available#2257
Test Result Analyzer fails if no stack trace is available#2257FreundDK wants to merge 20 commits into
Conversation
Dependencies
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the AnalyzeTests action when a <failure> XML element has no stack trace content by switching from the XML "#text" accessor (which can be $null) to InnerText (empty string for empty nodes).
Changes:
- Replace
$failure."#text"with$failure.InnerTextwhen rendering and storing stack traces inGetTestResultSummaryMD.
aholstrup1
left a comment
There was a problem hiding this comment.
LGTM. Missing a releasenote though
|
@aholstrup1 - any chance we can get this small bugfix in? |
|
Of course @freddydk - Sorry about the wait :) We just shipped v9.1. Can I get you to update the release note in this PR? Once it's updated we'll get it merged |
Done |
|
@FreundDK Looks like there is a merge conflict somewhere (I'm guessing in the releasenotes) 🙃 |
❔What, Why & How
Fixes #2256
TestResultAnalyzer uses "#Text", which might be null instead of InnerText
This code shows what is wrong with that: