Genericize freddyk references in docs examples - #2326
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Replaces personal GitHub account names in documentation examples with the generic myuser placeholder.
Changes:
- Generalizes clone URL and template examples.
- Updates the E2E GitHub owner example.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
Scenarios/GetStarted.md |
Generalizes the example clone URL. |
Scenarios/Contribute.md |
Generalizes owner and template references. |
…AppSource template description Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…and comments Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (1)
Scenarios/GetStarted.md:27
- The PR description says this change should replace the sample clone URL with
https://github.com/myuser/app1.git, but the example is removed instead. Restore the generic example or update the stated change so the implementation and PR scope agree.
1. Choose the **Code** button and copy the **https Clone Url**
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (2)
Scenarios/GetStarted.md:27
- The PR description says this URL is replaced with
https://github.com/myuser/app1.git, but the change removes the example entirely. Keep the generic URL so the implementation matches the documented change and readers still have a concrete clone-URL example.
1. Choose the **Code** button and copy the **https Clone Url**
Workshop/Dependencies2.md:79
- This file is outside the PR's explicitly stated two-file scope; the description says references in the workshop, workflows, and E2E test data were intentionally left untouched. Either revert these additional edits or update the PR description and changed-file list so reviewers can assess the actual scope.
"repo": "myorg/Common",
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (3)
Workshop/Dependencies2.md:79
- The PR description explicitly limits the change to two scenario documents and says workshop, workflow, and E2E references were intentionally left untouched, but this hunk and three other files modify those references. Either revert the out-of-scope edits or update the PR description so its stated scope matches the reviewed diff.
"repo": "myorg/Common",
.github/workflows/E2E.yaml:38
- This genericized URL points to the nonexistent
contoso/navcontainerhelperrepository, so users who copy the documented direct-download example receive a 404. Keep the example impersonal while using the canonical public repository and its currentmainbranch.
description: Which version of BcContainerHelper to use? (latest, preview, private, a specific version number or a direct download URL like https://github.com/microsoft/navcontainerhelper/archive/main.zip - leave empty to use latest)
.github/workflows/Deploy.yaml:32
- This genericized URL points to the nonexistent
contoso/navcontainerhelperrepository, so users who copy the documented direct-download example receive a 404. Use the canonical public repository and its currentmainbranch instead.
description: 'Which version of BcContainerHelper to use? (latest, preview, private, a specific version number or a direct download URL like https://github.com/microsoft/navcontainerhelper/archive/main.zip). Leave empty to use latest (or preview for preview branches)'
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
Workshop/Dependencies2.md:79
- The PR description says the change is scoped to the two
Scenariosdocuments and explicitly says workshop, workflow, and E2E references were left untouched, but this file and three non-Scenario files are also modified. Either revert those out-of-scope edits or update the PR description and change list to reflect the expanded scope.
"repo": "myorg/Common",
Scenarios/GetStarted.md:27
- The PR description says this example will become
https://github.com/myuser/app1.git, but the implementation removes the example entirely. Restore the generic example URL or update the description so the documented change matches the code.
1. Choose the **Code** button and copy the **https Clone Url**
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
Workshop/Dependencies2.md:79
- The PR description says the change is scoped to
Scenarios/GetStarted.mdandScenarios/Contribute.md, with workshop, workflow, and E2E references intentionally untouched, but this change also modifiesWorkshop/Dependencies2.md, both workflows, ande2eTests/e2eTestHelper.psm1. Please update the description and change list to reflect the actual scope, or revert the out-of-scope edits.
"repo": "myorg/Common",
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
Workshop/Dependencies2.md:79
- The PR description explicitly says the change is scoped to the two
Scenarios/files and that other personal references were intentionally left untouched, but this file—ande2eTestHelper.psm1plus both workflow files—is also modified. Please either update the stated scope/change list to cover these edits or revert the out-of-scope changes so the review contract matches the diff.
"repo": "myorg/Common",
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
Workshop/Dependencies2.md:79
- The PR description says the change is scoped to
Scenarios/GetStarted.mdandScenarios/Contribute.md, and explicitly says Workshop/workflow/E2E references were left untouched. This change, along with edits ine2eTests/e2eTestHelper.psm1and two workflows, materially exceeds that stated scope. Either revert the four out-of-scope files or update the description and change list to cover them.
"repo": "myorg/Common",
…yuser in e2e helper comment Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Replaces personal
freddyk/freddydkaccount names in AL-Go documentation and example text with generic placeholders (myuserfor a user/owner,myorgfor an organization).Changes
$global:E2EgitHubOwner,$global:pteTemplate, and$global:appSourceTemplateexamples now usemyuser; also corrected theappSourceTemplatedescription (was mislabeled "PTE template").microsoft/navcontainerhelper/archive/main.zip.myuser.freddydkorg→myorg(repo, NuGet serverUrl, and accompanying prose).Intentionally left unchanged
"freddydk": "businesscentralapps"is functional E2E config (read byGetOwnerForE2ETests.ps1/E2E.yaml); changing it would break E2E runs.FreddyDK.Licensing/ "Freddy Kristiansen as the publisher" accurately describe the realmicrosoft/bcsamples-bingmaps.appsourcesample repo, so genericizing would make the doc inaccurate.