Skip to content

[SOA] Bound outbound reply retries#9541

Merged
qasimikram merged 10 commits into
mainfrom
bugs/642291-bounded-reply-retries
Jul 23, 2026
Merged

[SOA] Bound outbound reply retries#9541
qasimikram merged 10 commits into
mainfrom
bugs/642291-bounded-reply-retries

Conversation

@qasimikram

@qasimikram qasimikram commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • cap failed outbound reply attempts at five per message
  • suppress exhausted replies without recurring telemetry
  • add a Retry sending action that resets the attempt count
  • isolate individual reply failures so remaining messages continue processing

Validation

  • compiled the Sales Order Agent app
  • ran CodeCop, AppSourceCop, PerTenantExtensionCop, and UICop

Fixes AB#642291

Stop retrying failed outbound replies after five attempts and allow users to reset exhausted retries from the message page.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@qasimikram
qasimikram requested a review from a team July 16, 2026 14:07
@github-actions github-actions Bot added the AL: Apps (W1) Add-on apps for W1 label Jul 16, 2026
@qasimikram qasimikram added the SCM GitHub request for SCM area label Jul 16, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 16, 2026
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Integration/SOAReplyRetryMgt.Codeunit.al Outdated
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Integration/SOASendReplies.Codeunit.al Outdated
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Permissions/SOAObjects.PermissionSet.al Outdated
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Integration/SOAReplyRetryMgt.Codeunit.al Outdated
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Integration/SOASendReplies.Codeunit.al Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: completed

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Findings by domain

Findings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).

Domain Findings Knowledge-backed Agent Inline Fallback
Error Handling 1 1 0 1 0
Performance 1 1 0 1 0
Privacy 1 1 0 1 0
Security 2 2 0 2 0
Style 1 1 0 1 0
Telemetry 1 1 0 1 0
Testing 1 1 0 0 0

Totals: 8 knowledge-backed · 0 agent findings.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

PredragMaricic
PredragMaricic previously approved these changes Jul 20, 2026
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Integration/SOAReplyRetryMgt.Codeunit.al Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Integration/SOASendReplies.Codeunit.al Outdated
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Integration/SOAReplyRetryMgt.Codeunit.al Outdated
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Integration/SOASendReplies.Codeunit.al Outdated
Comment thread src/Apps/W1/SalesOrderAgent/app/src/Integration/SOADispatcher.Codeunit.al Outdated
qikram added 2 commits July 22, 2026 16:05
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: cda27b36-a839-43cf-9734-41c2648954ed
@qasimikram
qasimikram enabled auto-merge July 22, 2026 15:05
@qasimikram
qasimikram added this pull request to the merge queue Jul 23, 2026
Merged via the queue into main with commit 0e0cc04 Jul 23, 2026
328 of 330 checks passed
@qasimikram
qasimikram deleted the bugs/642291-bounded-reply-retries branch July 23, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants