Skip to content

Add missing Elec. VAT Decl. Rep. Frequency enum to fix DK Clean build#9574

Closed
djukicmilica with Copilot wants to merge 5 commits into
mainfrom
copilot/fix-github-actions-job
Closed

Add missing Elec. VAT Decl. Rep. Frequency enum to fix DK Clean build#9574
djukicmilica with Copilot wants to merge 5 commits into
mainfrom
copilot/fix-github-actions-job

Conversation

Copilot AI commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

PR #9543 introduced frequency-aware VAT return period parsing for the Danish Electronic VAT Declaration app but omitted the enum file it depends on, causing error AL0185: Enum 'Elec. VAT Decl. Rep. Frequency' is missing in the DK Clean CI build.

Changes

  • New enum ElecVATDeclRepFrequency.Enum.al (ID 13605, namespace Microsoft.Finance.VAT.Reporting):

    enum 13605 "Elec. VAT Decl. Rep. Frequency"
    {
        value(0; Monthly)   { Caption = 'Monthly'; }
        value(1; Quarterly) { Caption = 'Quarterly'; }
        value(2; "Semi-Annual") { Caption = 'Semi-Annual'; }
    }

    Values correspond to Danish SKAT frequency strings: Måned → Monthly, Kvartal → Quarterly, Halvår → Semi-Annual.

  • Includes all three commits from PR Support VAT return reporting frequencies in Denmark #9543 (cherry-picked):

    • Frequency-aware VAT period parsing (GetFrequencyAwareVATReturnPeriods, CalcPeriodEndDate, CalcPeriodStartDate)
    • Feature flag via Azure Key Vault (IsReportingFrequencyEnabled)
    • Overlapping-period guard and legacy quarterly fallback
    • Test coverage for all frequency paths and the feature flag
    • internalsVisibleTo in app.json so the test app can access Access = Internal codeunits

@github-actions github-actions Bot added the needs-approval Workflow runs require maintainer approval to start label Jul 17, 2026
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Build Apps DK (Clean) Add missing Elec. VAT Decl. Rep. Frequency enum to fix DK Clean build Jul 17, 2026
Copilot AI requested a review from djukicmilica July 17, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-approval Workflow runs require maintainer approval to start

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants