[Payables Agent] Write transaction in Payable Agent code triggered by Confirm dialog#9647
Open
Explorer986 wants to merge 1 commit into
Open
[Payables Agent] Write transaction in Payable Agent code triggered by Confirm dialog#9647Explorer986 wants to merge 1 commit into
Explorer986 wants to merge 1 commit into
Conversation
…ring display checks GetAgent unconditionally called PayablesAgentSetup.Modify(), opening a write transaction even when nothing changed. When invoked from agent action visibility checks (ShowCanCreateAgent) around a Confirm dialog, this left an open write transaction that blocked subsequent Page.RunModal calls. Now only persist when the setup record actually changed.
github-actions
Bot
added
AL: Apps (W1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
GetAgent unconditionally called PayablesAgentSetup.Modify(), opening a write transaction even when nothing changed. When invoked from agent action visibility checks (ShowCanCreateAgent) around a Confirm dialog, this left an open write transaction that blocked subsequent Page.RunModal calls. Now only persist when the setup record actually changed.
Fixes AB#641849
How I validated this