[releases/28.x] [Shopify] Fix missing shop currency mapping on order transactions#9665
Open
onbuyuka wants to merge 1 commit into
Open
[releases/28.x] [Shopify] Fix missing shop currency mapping on order transactions#9665onbuyuka wants to merge 1 commit into
onbuyuka wants to merge 1 commit into
Conversation
github-actions
Bot
added
AL: Apps (W1)
) ## Problem The `amountSet.shopMoney.currencyCode` was no longer mapped to the `Currency` field on `Shpfy Order Transaction` records. This regression was introduced in commit acd8280 (presentment currency support) where the existing `shopMoney.currencyCode` mapping was accidentally **replaced** by the new `presentmentMoney` lines instead of being kept alongside them. This causes the **Currency** column on the **Shopify Order Transactions** page to show stale/incorrect values from prior sync runs or remain empty for new transactions - while `TranslateCurrencyCode(OrderTransaction.Currency)` is called expecting the field to be populated. ## Root Cause In commit [acd8280](acd8280#diff-59120ecd686f94a2f2778d8fe2529eabab25319f10f8ee62ff1f5485d7eb7850), the shopMoney.currencyCode line was replaced by presentmentMoney lines instead of being kept alongside them. ## Fix Re-add the missing `amountSet.shopMoney.currencyCode` to `Currency` mapping, restoring parity with how `amountRoundingSet` correctly handles both shopMoney and presentmentMoney currency codes in the same block. ## Verification - The GraphQL query (ShpfyGQLOrderTransactions.Codeunit.al) already requests `shopMoney { amount currencyCode }` - the data was available but not being read. - The `TranslateCurrencyCode` call on line 121 correctly handles the raw Shopify currency code once populated. - The `amountRoundingSet` block (lines 99-102) was already correct (both shopMoney and presentmentMoney mapped). Fixes [AB#641570](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/641570) Ref: ICM 51000001074581 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: onbuyuka <55088871+onbuyuka@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b1f006ac-3ace-495d-8b5c-9b76510cf117
onbuyuka
force-pushed
the
bugs/643244-backport
branch
from
July 22, 2026 11:54
e225d39 to
44a763f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of bug #641570 to releases/28.x.
Fixes AB#643244
Original PR: #8679