[releases/28.x] [Shopify] Skip refund credit memo while transaction is pending#9666
Open
onbuyuka wants to merge 1 commit into
Open
[releases/28.x] [Shopify] Skip refund credit memo while transaction is pending#9666onbuyuka wants to merge 1 commit into
onbuyuka wants to merge 1 commit into
Conversation
github-actions
Bot
added
AL: Apps (W1)
darjoo
previously approved these changes
Jul 23, 2026
Fixes [AB#640432](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/640432) When a Shopify refund is synced while its payment transaction is still **pending**, Shopify's `totalRefundedSet` returns 0 (it only counts `SUCCESS` transactions). If a credit memo is created at that moment, the balancing line in `CreateSalesLinesFromRemainingAmount` calculates `Unit Price = 0 - <item total>`, producing a credit memo whose total is 0 — a financially useless document. `ShpfyCreateSalesDocRefund.Codeunit.al` balances the document against `RefundHeader."Total Refunded Amount"`, which is 0 while the refund transaction is still pending, even though the item/return lines already sum to the real amount. Block credit memo / return order creation while the refund still has a pending transaction, mirroring the existing `"Can Create Credit Memo"` dual-guard pattern: - **`ShpfyRefundsAPI.Codeunit.al`** — new internal helper `HasPendingRefundTransactions(RefundId)` that checks for refund transactions with `Type = Refund` and `Status = Pending`. `VerifyRefundCanCreateCreditMemo` now throws a clear error when a pending transaction exists (manual **Create Sales Document** path). - **`ShpfyRetRefProcCrMemo.Codeunit.al`** — `CreateSalesDocument` now exits early (silent skip) when the refund still has a pending transaction (auto-sync path). The refund stays unprocessed and is retried on the next sync; once the transaction reaches `SUCCESS`, `totalRefundedSet` is final and the credit memo is created correctly. This is safe because the auto-processing loop (`ProcessShopifyRefunds`) retries all unprocessed refunds on every sync, and no data is guessed or approximated. Added to `ShpfyOrderRefundTest.Codeunit.al` (with a `CreateRefundTransaction` helper in `ShpfyOrderRefundsHelper.Codeunit.al`): - `UnitTestDoesNotCreateCrMemoFromRefundWithPendingTransaction` — no credit memo is created while the refund has a pending transaction. - `UnitTestCreatesCrMemoFromRefundWithSucceededTransaction` — the guard is specific to pending; a succeeded transaction still creates the credit memo. - `UnitTestVerifyRefundCanCreateCreditMemoErrorsWithPendingTransaction` — the manual path throws the pending-transaction error. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b1f006ac-3ace-495d-8b5c-9b76510cf117
onbuyuka
force-pushed
the
bugs/643243-backport
branch
from
July 23, 2026 12:10
8f4084b to
62c2704
Compare
onbuyuka
enabled auto-merge (squash)
July 24, 2026 08:54
mynjj
approved these changes
Jul 24, 2026
auto-merge was automatically disabled
July 24, 2026 11:54
Pull request was closed
onbuyuka
enabled auto-merge (squash)
July 24, 2026 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of bug #640432 to releases/28.x.
Fixes AB#643243
Original PR: #9112
Cherry-picked #9112's merge commit. Two files needed manual conflict resolution because
releases/28.xpredates a later ""return order"" feature: kept the 28.x wording of the existingRefundCantCreateCreditMemoErrlabel and omitted the unrelatedShoplookup that isn't present on this branch. The fix itself (newHasPendingRefundTransactionshelper, the two guard calls, and theRefund Id/Type/Statuskey) is applied unchanged.Test plan
Includes the tests added in #9112:
UnitTestDoesNotCreateCrMemoFromRefundWithPendingTransactionUnitTestCreatesCrMemoFromRefundWithSucceededTransactionUnitTestVerifyRefundCanCreateCreditMemoErrorsWithPendingTransaction