Declare TempCustomMigrationTableBuffer as temporary#9699
Closed
gggdttt wants to merge 1 commit into
Closed
Conversation
Keeps AddCustomMigrationMapping in sync with the NAV 28.x backport and satisfies AA0237 under stricter rulesets. The backing table (Custom Migration Table Buffer) is TableType=Temporary, so the keyword is runtime-redundant and behavior-preserving.
Contributor
|
Could not find a linked ADO work item. Please link one by using the pattern 'AB#' followed by the relevant work item number. You may use the 'Fixes' keyword to automatically resolve the work item when the pull request is merged. E.g. 'Fixes AB#1234' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declares
TempCustomMigrationTableBufferastemporaryinAddCustomMigrationMapping.Page.al.Why
This keeps
mainin sync with the NAV 28.x backport of the BC14 cloud migration fixes (PR #9200). On NAV 28.x, the build ruleset (app.ruleset.json,generalAction: Error) promotesAA0237— "The name of non temporary variables must not be prefixed with Temp" — to a build-breaking error, whereas the BCApps build treats it as a warning. Adding the keyword there was required to build; this PR applies the same change onmainso the two branches don't diverge.Risk
None. The backing table
Custom Migration Table Buffer(40035) is alreadyTableType = Temporary, so thetemporarykeyword is runtime-redundant and behavior-preserving.