Skip to content

[DO NOT MERGE] Implementation plan and Addressing Gaps#172

Open
apurvabanka wants to merge 2 commits into
jonguy/workday-skills-planfrom
apurv/implementation-plan
Open

[DO NOT MERGE] Implementation plan and Addressing Gaps#172
apurvabanka wants to merge 2 commits into
jonguy/workday-skills-planfrom
apurv/implementation-plan

Conversation

@apurvabanka

Copy link
Copy Markdown
Contributor

This PR is for Implementation Plan for flight checks.
This includes how we are addressing the Gaps in the /connet workday skill.

@amilandi amilandi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the planning docs — well-structured and technically coherent. Each gap follows a consistent pattern (gap → skill fix → flightcheck proof → status), open items and coverage reductions are explicitly called out, and no secrets or sensitive data in the docs.

A few notes:

  • The JWT vs SAML Bearer Grant reconciliation in step-2 is flagged as a blocker — worth resolving before coding starts.
  • WD-ENTRA-SCOPE-001 bundles 3 concerns into one composite check, which the doc itself flags as tension with the "one check, one concern" rule. Worth a decision on split vs. composite before implementation.
  • Good that the docs are transparent about Workday's lack of admin API — the manual attestation fallbacks are reasonable given that constraint.

@nehaoss

nehaoss commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

👋 Friendly reminder: This PR has been inactive for a while. Could the author or reviewers take a look and either push it forward, request changes, or close it if it's no longer needed? Let's keep our PR queue healthy! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants