[DO NOT MERGE] Implementation plan and Addressing Gaps#172
Open
apurvabanka wants to merge 2 commits into
Open
Conversation
amilandi
reviewed
Jun 26, 2026
amilandi
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the planning docs — well-structured and technically coherent. Each gap follows a consistent pattern (gap → skill fix → flightcheck proof → status), open items and coverage reductions are explicitly called out, and no secrets or sensitive data in the docs.
A few notes:
- The JWT vs SAML Bearer Grant reconciliation in step-2 is flagged as a blocker — worth resolving before coding starts.
WD-ENTRA-SCOPE-001bundles 3 concerns into one composite check, which the doc itself flags as tension with the "one check, one concern" rule. Worth a decision on split vs. composite before implementation.- Good that the docs are transparent about Workday's lack of admin API — the manual attestation fallbacks are reasonable given that constraint.
Contributor
|
👋 Friendly reminder: This PR has been inactive for a while. Could the author or reviewers take a look and either push it forward, request changes, or close it if it's no longer needed? Let's keep our PR queue healthy! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for Implementation Plan for flight checks.
This includes how we are addressing the Gaps in the /connet workday skill.