Updated code linting reports#2619
Merged
Merged
Conversation
… And added to build-ts to gate builds.
…ibute sanitization' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…rosoft/TypeAgent into dev/robgruen/code_complexity
…ist to each report/gate/check. pnpm lint now runs these checks in addition to prettier
…rosoft/TypeAgent into dev/robgruen/code_complexity
…rosoft/TypeAgent into dev/robgruen/code_complexity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and cleanups to the code quality tooling and tests, focusing on making code debt gating more robust and maintainable. It adds support for baseline exceptions in code quality gates, improves skipped/focused test detection, re-enables a previously skipped grammar test, and replaces a dead test with a more meaningful one. There are also small updates to documentation and npm scripts to reflect these changes.
Code quality tooling enhancements:
--exceptions-file) to thecode-lint,code-complexity,code-debt, andcode-circulartools, allowing known issues to be grandfathered and not block the ratchet/gate. Exception file format and usage are documented inREADME.md. [1] [2] [3] [4] [5] [6] [7]code-debttooling: now recognizes.skip.eachand.only.each, and ignores placeholder stubs (empty() => {}bodies). [1] [2] [3]Test and CI improvements:
CalendarDategrammar loader test indynamicGrammarLoader.spec.tsnow that the required converter exists, and updated its expected output to match the new slot value format. [1] [2]api/test/api.spec.tsand replaced it with a real web server smoke test inapi.test.tsthat exercises static file serving and 404 handling. [1] [2]code-lintandlint:fixnpm scripts to use the new ratchet/gate mechanisms and only fix changed files. [1] [2]Documentation updates:
README.mdto reflect new test debt numbers (skipped tests down to 2, both intentional), improved explanations of the ratchet/gate process, and documented the new baseline exception mechanism. [1] [2] [3] [4]Other minor improvements:
circularDepsReport.tsandcomplexityReport.tsto show all relevant results instead of slicing to a top-N, and improved output for baseline exceptions. [1] [2]These changes collectively make code quality enforcement more flexible and accurate, while reducing false positives and technical debt noise.