Support abstract collection types in Python#169
Merged
Conversation
DanielRosenwasser
changed the title
DanielRosenwasser
requested review from
ahejlsberg,
hillary-mutisya and
pcdeadeasy
hillary-mutisya
approved these changes
Jan 19, 2024
…pport Reconcile python_type_to_ts_nodes.py with current main: keep 'import typing_extensions' (now used throughout the file), add 'import collections.abc' and a direct 'Self' import. Enable abstract collection types in _LIST_TYPES/_DICT_TYPES and use 'Self' and 'origin in _DICT_TYPES'. Replace the standalone tests/abstract_collections.py script with a proper syrupy snapshot test (tests/test_abstract_collections.py) matching current conventions; extend coverage to Iterable/Collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is part clean-up, part feature addition.
Now that microsoft/pyright#6582 is fixed, we can use all the collection types as values and support them as annotations.
Now that microsoft/pyright#6587 is fixed, we can directly reference
Self.