Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: expand Connection Property Suffix migration guidance for Aspire 13.2 #1167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: expand Connection Property Suffix migration guidance for Aspire 13.2 #1167
Changes from all commits
da99d8857da37aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shipped in 13.1 via backport #13516 (commit
d6668f5is inv13.1.0), so this section is on the wrong release page and the 13.2/≤13.1 boundaries are off by one. Could we move this to the 13.1 page and use ≤13.0/13.1?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Several Azure resources listed here never shipped with the old unsuffixed names; their connection properties were introduced already suffixed in 13.1. Could we limit the migration table to resources that actually had a released rename?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AzureOpenAIDeploymentResource.ModelNameresolves to the deployment name, not the underlying model ID, sogpt-4o-miniis misleading here. Could we use a GitHub Models example, or show the actual deployment name?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also matches already-migrated names like
_DATABASENAME/_MODELNAME, and it doesn't find the directGetConnectionProperty("...")calls covered in step 3. Could we anchor the old suffixes and add a second search for those property keys?