fix(codegen): accept React.ComponentRef in command first-arg - #3045
Open
ramonclaudio wants to merge 1 commit into
Open
fix(codegen): accept React.ComponentRef in command first-arg#3045ramonclaudio wants to merge 1 commit into
ramonclaudio wants to merge 1 commit into
Conversation
React 19 renamed `React.ElementRef` to `React.ComponentRef`. The TypeScript commands parser only accepts `ElementRef`, so a NativeCommand whose first arg is typed as `React.ComponentRef` fails codegen with "The first argument of method <name> must be of type React.ElementRef<>". Forward-ports react#54274 (by Mike Hardy): accept both names and update the error message. This unblocks libraries that moved to `ComponentRef`, like react-native-screens 4.26, whose command spec currently breaks the macOS codegen.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@microsoft-github-policy-service agree |
1 similar comment
Author
|
@microsoft-github-policy-service agree |
Author
|
Mind taking a look? @Saadnajmi @tido64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-port of react#54274.
React 19 renamed
React.ElementReftoReact.ComponentRef, and the TypeScript commands parser here only acceptsElementRef, so a command typed withComponentReffails codegen.react-nativemain already takes both.react-native-macosmain and0.81-stabledon't.It shows up with
react-native-screens@4.26, which types a command's first arg asReact.ComponentRef<>.ElementRefstill works, so nothing that passed before stops passing.Test plan
Locally
yarn jest packages/react-native-codegenpasses 2936 tests, and prettier, eslint andyarn flow checkare clean.