-
Notifications
You must be signed in to change notification settings - Fork 375
Deprecate old testing framework in favor of createTester
#10964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
9
commits into
main
Choose a base branch
from
copilot/deprecate-old-testing-framework
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1290322
Initial plan
Copilot 15e3b13
deprecate: add @deprecated JSDoc to old testing framework APIs and ex…
Copilot c329a7d
fix: remove already-deprecated packages from changelog entry
Copilot ed3b9f3
fix: remove deleted testing template files from scaffolding.json
Copilot 0e966be
Merge branch 'main' into copilot/deprecate-old-testing-framework
timotheeguerin deea406
fix: suppress no-deprecated lint warnings in deprecated testing imple…
Copilot ba53039
refactor: replace file-level eslint-disable with targeted suppressions
Copilot 5d3e6a5
fix: add missing packages to deprecation changelog entry
Copilot 2c12d16
Merge branch 'main' into copilot/deprecate-old-testing-framework
timotheeguerin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
23 changes: 23 additions & 0 deletions
23
.chronus/changes/deprecate-old-testing-framework-2026-6-11.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| changeKind: deprecation | ||
| packages: | ||
| - "@typespec/compiler" | ||
| - "@typespec/http" | ||
| - "@typespec/rest" | ||
| - "@typespec/versioning" | ||
| - "@typespec/json-schema" | ||
| - "@typespec/xml" | ||
| - "@typespec/events" | ||
| - "@typespec/sse" | ||
| - "@typespec/streams" | ||
| - "@typespec/html-program-viewer" | ||
| - "@typespec/library-linter" | ||
| - "@typespec/emitter-framework" | ||
| - "@typespec/http-client-js" | ||
| - "@typespec/http-client" | ||
| - "@typespec/http-server-js" | ||
| - "@typespec/openapi" | ||
| - "@typespec/openapi3" | ||
| --- | ||
|
|
||
| Deprecate old testing framework (`createTestHost`, `createTestRunner`, `createTestWrapper`, `createTestLibrary`, `BasicTestRunner`, `TypeSpecTestLibrary`, etc.). Use `createTester` from `@typespec/compiler/testing` instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 0 additions & 8 deletions
8
packages/compiler/templates/__snapshots__/emitter-ts/src/testing/index.ts
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
packages/compiler/templates/__snapshots__/library-ts/src/testing/index.ts
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
packages/compiler/templates/emitter-ts/src/testing/index.ts.mu
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
packages/compiler/templates/library-ts/src/testing/index.ts.mu
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| import { createTestLibrary, findTestPackageRoot } from "@typespec/compiler/testing"; | ||
|
|
||
| /** @deprecated Use `createTester` from `@typespec/compiler/testing` instead */ | ||
| /* eslint-disable @typescript-eslint/no-deprecated */ | ||
| export const EventsTestLibrary = createTestLibrary({ | ||
| name: "@typespec/events", | ||
| packageRoot: await findTestPackageRoot(import.meta.url), | ||
| }); | ||
| /* eslint-enable @typescript-eslint/no-deprecated */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we removing these files as part of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole purpose of this file was to define the Testing library only used in framework v1