Skip to content

Fix clang-format/clang-tidy version check failing on Windows (and paths with spaces) #14552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sean-mcmanus wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −4
Open

Fix clang-format/clang-tidy version check failing on Windows (and paths with spaces) #14552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
648a2f5
Fix clang-format/clang-tidy version check failing on Windows (and pat…
sean-mcmanus Jun 27, 2026
2cc7176
Fix Copilot review comment.
sean-mcmanus Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Extension/src/LanguageServer/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@
* ------------------------------------------------------------------------------------------ */
'use strict';

import { execSync } from 'child_process';
import { execFileSync } from 'child_process';
import * as os from 'os';
import * as path from 'path';
import * as semver from 'semver';
import { quote } from 'shell-quote';
import * as vscode from 'vscode';
import * as nls from 'vscode-nls';
import * as which from 'which';
Expand Down Expand Up @@ -297,7 +296,7 @@ export class CppSettings extends Settings {
let bundledVersion: string;
try {
const bundledPath: string = getExtensionFilePath(`./LLVM/bin/${clangName}`);
const output: string = execSync(quote([bundledPath, '--version'])).toString();
const output: string = execFileSync(bundledPath, ['--version']).toString();
bundledVersion = output.match(/(\d+\.\d+\.\d+)/)?.[1] ?? "";
Comment thread
sean-mcmanus marked this conversation as resolved.
if (!semver.valid(bundledVersion)) {
return path;
Expand All @@ -309,7 +308,7 @@ export class CppSettings extends Settings {

// Invoke the version on the system to compare versions. Use ours if it's more recent.
try {
const output: string = execSync(`"${path}" --version`).toString();
const output: string = execFileSync(path, ['--version']).toString();
const userVersion = output.match(/(\d+\.\d+\.\d+)/)?.[1] ?? "";
if (semver.ltr(userVersion, bundledVersion)) {
path = "";
Expand Down
Loading