🛡️ Sentinel: [HIGH] Fix path traversal in employee portrait loading - #219
🛡️ Sentinel: [HIGH] Fix path traversal in employee portrait loading#219mleem97 wants to merge 1 commit into
Conversation
🚨 Severity: HIGH
💡 Vulnerability: The `employeeId` parameter in `CustomEmployeeManager.SetPortrait` was directly concatenated into a file path without secondary validation. While validated at registration, direct calls or deserialization could bypass this and lead to path traversal attacks.
🎯 Impact: An attacker could potentially access or load arbitrary files outside of the intended `ModAssets` directory.
🔧 Fix: Added a defense-in-depth boundary check (`IndexOfAny(Path.GetInvalidFileNameChars()) < 0 && !Contains("..")`) around the file loading logic. Designed the patch to skip file loading on invalid input while allowing the fallback UI color assignment to still execute.
✅ Verification: The test suite was run and confirmed passing. The changes prevent directory traversal characters from reaching `Path.Combine`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 high |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
1 participant
🚨 Severity: HIGH
💡 Vulnerability: The
employeeIdparameter inCustomEmployeeManager.SetPortraitwas directly concatenated into a file path without secondary validation. While validated at registration, direct calls or deserialization could bypass this and lead to path traversal attacks.🎯 Impact: An attacker could potentially access or load arbitrary files outside of the intended
ModAssetsdirectory.🔧 Fix: Added a defense-in-depth boundary check (
IndexOfAny(Path.GetInvalidFileNameChars()) < 0 && !Contains("..")) around the file loading logic. Designed the patch to skip file loading on invalid input while allowing the fallback UI color assignment to still execute.✅ Verification: The test suite was run and confirmed passing. The changes prevent directory traversal characters from reaching
Path.Combine.PR created automatically by Jules for task 9271677534405968814 started by @mleem97