⚡ Bolt: Optimize Lua Server queries - #224
Conversation
…th NetworkMap lookups
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…th NetworkMap lookups
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 6 |
| Duplication | 2 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
💡 What: Replaced O(N)
FindObjectsOfType<Il2Cpp.Server>()calls inLuaServerModule.cswith O(1) lookups usingNetworkMap.instance.serversandNetworkMap.instance.brokenServers.🎯 Why:
FindObjectsOfTypeis a very expensive Unity scene graph query, and executing it repeatedly (especially from Lua scripts in loops) causes significant main thread stuttering.📊 Impact: Changes O(N) scene scans to O(1) dictionary iterations, reducing the time complexity of
get_all,repair, andrepair_allsignificantly when many objects exist.🔬 Measurement: Run the game with a large number of servers and call
greg.server.get_all()from a Lua script. Monitor the frame time; stuttering should be eliminated.PR created automatically by Jules for task 2422886843577138954 started by @mleem97