Skip to content

⚡ Bolt: Optimize FindObjectsOfType polling in Lua API - #226

Open
mleem97 wants to merge 2 commits into
mainfrom
bolt-optimize-luaserver-api-4474689182492539833
Open

⚡ Bolt: Optimize FindObjectsOfType polling in Lua API#226
mleem97 wants to merge 2 commits into
mainfrom
bolt-optimize-luaserver-api-4474689182492539833

Conversation

@mleem97

@mleem97 mleem97 commented Aug 8, 2026

Copy link
Copy Markdown
Owner

💡 What: Optimized LuaServerModule.cs to eliminate O(N) FindObjectsOfType<Il2Cpp.Server>() calls by using game-managed Il2Cpp.NetworkMap.instance.servers and brokenServers dictionary caches.
🎯 Why: Lua endpoint calls to get or manipulate server lists (via get_all, repair, or repair_all) previously triggered full scene hierarchy scans (FindObjectsOfType), which allocates arrays on the heap and creates severe CPU spikes on each evaluation, especially in large data centers.
📊 Impact: Changes O(N) scene scans to O(1) collection references. Significantly reduces main thread blocking and IL2CPP GC pressure, yielding dramatically improved framerates when Lua API endpoints are frequently polled.
🔬 Measurement: Can be verified by running any Lua script calling greg.server.get_all() or greg.server.repair_all() in a loop. Measure the reduction in main thread time using the Unity Profiler.


PR created automatically by Jules for task 4474689182492539833 started by @mleem97

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 1 high

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Security 1 high

View in Codacy

🟢 Metrics 11 complexity · 2 duplication

Metric Results
Complexity 11
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant