⚡ Bolt: Optimize LuaServerModule API with O(1) NetworkMap lookups - #228
⚡ Bolt: Optimize LuaServerModule API with O(1) NetworkMap lookups#228mleem97 wants to merge 2 commits into
Conversation
Replaces expensive O(N) `FindObjectsOfType<Server>()` calls with O(1) singletons to prevent CPU and GC spikes when mod scripts poll these endpoints.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Replaces expensive O(N) `FindObjectsOfType<Server>()` calls with O(1) singletons to prevent CPU and GC spikes when mod scripts poll these endpoints.
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| Security | 1 high |
🟢 Metrics 14 complexity · 0 duplication
Metric Results Complexity 14 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
1 participant
💡 What: Optimize
greg.server.get_all,repair, andrepair_allLua APIs to useIl2Cpp.NetworkMap.instancedictionaries instead ofFindObjectsOfType<Server>().🎯 Why:
FindObjectsOfTypescans the entire scene hierarchy, which blocks the main thread and creates GC overhead. Since these Lua functions can be called frequently (or polled) by mod scripts, this causes major performance hitches in large data centers.📊 Impact: Reduces O(N) scene-wide scanning to O(1) dictionary lookups or direct iteration over subset dictionaries, saving significant CPU cycles and reducing GC pressure. Added early return in
repair_allto avoid defensive list allocations when no servers are broken.🔬 Measurement: Check if the application remains responsive when a Lua mod repeatedly calls these endpoints in a scene with thousands of objects. Local tests pass successfully.
PR created automatically by Jules for task 3784942042951078918 started by @mleem97