Skip to content

Fix incorrect PAR in qtblend transition - #1273

Merged
ddennedy merged 2 commits into
mltframework:masterfrom
j-b-m:work/qtblend-transition-scale
Jul 27, 2026
Merged

Fix incorrect PAR in qtblend transition#1273
ddennedy merged 2 commits into
mltframework:masterfrom
j-b-m:work/qtblend-transition-scale

Conversation

@j-b-m

@j-b-m j-b-m commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

With the addition of normalize_mlt_source_size in 86b1877, the frames with a PAR != consumer PAR had their size adjusted twice, resulting in incorrectly sized images. A 1.3333 PAR 1440x1080 video (which should appear full screen in a 1920x1080 project) was scaled down and appeared with a large black border.

Kdenlive bug #522730

@ddennedy

Copy link
Copy Markdown
Member

@guiodic please review

@ddennedy ddennedy added this to the v7.42.0 milestone Jul 27, 2026
@guiodic

guiodic commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

@guiodic please review

That looks like an excellent solution to me

@ddennedy
ddennedy merged commit 43ec493 into mltframework:master Jul 27, 2026
15 checks passed
@ddennedy

ddennedy commented Aug 1, 2026

Copy link
Copy Markdown
Member

This change introduced a major regression reported here:
https://forum.shotcut.org/t/some-files-are-horribly-blurry-in-my-project/51785

I am going to revert it, but I wonder if I should revert 86b1877 as well.

I reproduce it with a command line like:
melt -profile atsc_1080p_25 color:white -track /path/to.png -attach affine transition.rect=25%,25%,50%,50% -transition qtblend
The PNG I am using is 512x512, less than 1920x1080.

ddennedy added a commit that referenced this pull request Aug 1, 2026
@guiodic

guiodic commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

I am going to revert it, but I wonder if I should revert 86b1877 as well.

I presume the bug can be fixed without reverting [86b1877] that commit solves a worse bug. I will try tomorrow.

I reproduce it with a command line like: melt -profile atsc_1080p_25 color:white -track /path/to.png -attach affine transition.rect=25%,25%,50%,50% -transition qtblend The PNG I am using is 512x512, less than 1920x1080.

Good, I will test a couple of ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants