ENH: support multiple simultaneous overlays in Brain.add_data#13995
Open
payamsash wants to merge 2 commits into
Open
ENH: support multiple simultaneous overlays in Brain.add_data#13995payamsash wants to merge 2 commits into
payamsash wants to merge 2 commits into
Conversation
Member
|
Yes @payamsash that sounds good to me! Related to:
We also have an issue with interactivity, in that the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
Closes #11503.
What does this implement/fix?
The rendering side is already ready (#13970), so it can keep multiple named overlays together. This PR is on the
Brainside so it can track more than one dataset at a time, and connectingremove_existing=Falseto actually work. so WDYT about these steps @larsoner?self._datato index datasets by key instead of overwriting, so multiple calls toadd_data(..., key="stats")andadd_data(..., key="data")can happen.remove_existing=Falseto callLayeredMesh.add_overlaywith a new key.