Update Charon submodule to v0.1.71#4669
Open
tautschnig wants to merge 1 commit into
Open
Conversation
Advance the Charon pin from v0.1.69 (485bd36e) to v0.1.71 (de910497), continuing the incremental effort to catch the pinned Charon up with upstream (the endgame is dropping scripts/charon-patch.diff entirely). Charon v0.1.70/71 make error levels explicit (`span_err` takes a `Level`) and add `ItemMeta::lang_item` tracking (`None` for the items Kani translates, which carry no `#[lang]` attribute). Refresh scripts/charon-patch.diff so its hunks apply against the v0.1.71 sources (context-line drift only; the patch content is unchanged). Co-authored-by: Kiro <kiro-agent@users.noreply.github.com>
github-actions
Bot
added
Z-EndToEndBenchCI
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Kani’s pinned Charon dependency to v0.1.71 and adapts the LLBC/Aeneas integration to Charon’s updated APIs (explicit error Level and new ItemMeta::lang_item field), while refreshing the local patch file so it continues to apply cleanly.
Changes:
- Update Charon references (including lockfile) to v0.1.71.
- Adjust LLBC codegen to pass Charon error
Leveland to populateItemMeta::lang_itemasNone. - Refresh
scripts/charon-patch.diffso it applies against the newer Charon sources.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/charon-patch.diff | Refreshes the maintained patch so it applies to the updated Charon sources. |
| kani-compiler/src/codegen_aeneas_llbc/mir_to_ullbc/mod.rs | Updates Charon error and metadata construction to match new Charon APIs (Level, lang_item). |
| kani-compiler/src/codegen_aeneas_llbc/compiler_interface.rs | Updates span_err call sites to pass an explicit Charon error Level. |
| Cargo.lock | Bumps the locked Charon package version to 0.1.71. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advance the Charon pin from v0.1.69 (485bd36e) to v0.1.71 (de910497), continuing the incremental effort to catch the pinned Charon up with upstream (the endgame is dropping scripts/charon-patch.diff entirely).
Charon v0.1.70/71 make error levels explicit (
span_errtakes aLevel) and addItemMeta::lang_itemtracking (Nonefor the items Kani translates, which carry no#[lang]attribute).Refresh scripts/charon-patch.diff so its hunks apply against the v0.1.71 sources (context-line drift only; the patch content is unchanged).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.