Skip to content

fix(server): deregister terminated streamable HTTP sessions - #3302

Closed
mikemikimike wants to merge 4 commits into
modelcontextprotocol:mainfrom
mikemikimike:codex/3300-session-deregister
Closed

fix(server): deregister terminated streamable HTTP sessions#3302
mikemikimike wants to merge 4 commits into
modelcontextprotocol:mainfrom
mikemikimike:codex/3300-session-deregister

Conversation

@mikemikimike

Copy link
Copy Markdown

Summary

  • remove terminated existing sessions from both session registries immediately after handling the request
  • add a regression test for the clean DELETE/session termination path

Fixes #3300

Validation

  • uv run --frozen ruff format ...
  • uv run --frozen ruff check src/mcp/server/streamable_http_manager.py tests/server/test_streamable_http_manager.py
  • uv run --frozen pyright src/mcp/server/streamable_http_manager.py tests/server/test_streamable_http_manager.py
  • uv run --frozen pytest tests/server/test_streamable_http_manager.py -q (31 passed)
  • git diff --check

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread tests/server/test_streamable_http_manager.py

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread tests/server/test_streamable_http_manager.py Outdated
@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Aug 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution. This repository only keeps pull requests open when they're linked to an issue that a maintainer has assigned to the author — CONTRIBUTING.md explains why and how we work. This PR has been closed for now because you aren't currently assigned to #3300.

If a maintainer would like this change as a PR from you, they'll assign you to #3300 and this PR will reopen automatically — there's nothing more you need to do. (If you opened the issue, this PR already shows up on its timeline.)

There's no need to open a new PR — this one will be reopened. While it's closed, please push any updates as new commits rather than force-pushing, since GitHub can't reopen a PR whose branch has been rewritten.

Maintainers: reopening this PR, removing the missing-issue-link label, or adding bypass-issue-check bypasses the check.

@github-actions github-actions Bot closed this Aug 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanly terminated streamable-HTTP sessions are never deregistered: the DELETE path skips its own cleanup

1 participant