fix: negotiate protocol version in handler#930
Open
actsalan wants to merge 2 commits into
Open
Conversation
83708af to
0f12a96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #916 - ensures
context.protocol_version()returns the negotiated version in all transports and modes.Motivation and Context
Three related bugs existed in protocol version handling:
serve_directlypassedNoneaspeer_info, socontext.protocol_version()was alwaysNonein handlersserve_servernegotiated the version in the initialize response but never updatedpeer_infoto match, so handlers saw the client's raw requested version instead of the negotiated oneServerHandler::initializedidn't apply negotiation logic, so the response could echo an unnegotiated versionHow Has This Been Tested?
test_protocol_version_negotiation.rs) and stateless HTTP (test_stateless_protocol_version.rs) transportsKNOWN_VERSIONSare correctly echoed back to clientsLATESTBreaking Changes
None. This fix maintains backward compatibility while ensuring correct protocol version negotiation.
Types of changes
Checklist
Additional context
Changes made:
tower.rs: Reconstructpeer_infoper-request fromMCP-Protocol-Versionheader for stateless modeservice/server.rs: Updatepeer_infoafter negotiation so subsequent handlers see the negotiated versionhandler/server.rs: Applynegotiate_protocol_versionin defaultinitializeresponse