fix: prevent OAuth resource spoofing#937
Merged
Merged
Conversation
michaelneale
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This fixes an OAuth protected-resource metadata spoofing issue by requiring discovered RFC 9728 metadata to identify the same MCP resource the client is connecting to. Without this check, a malicious MCP server could advertise another resource's authorization server and trick clients into sending access tokens to the wrong server. The change rejects missing or mismatched
resourcevalues before trusting advertised authorization servers or scopes, while preserving the root URL slash normalization needed for existing local-server flows.How Has This Been Tested?
Added tests
Breaking Changes
This is intended to be a non-breaking security fix.
Types of changes
Checklist
Additional context