Skip to content

Fix the bug in read_json_field function #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MengMengDaXiaoJi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the bug in read_json_field function #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions recipes/distilqwen_series/distillqwen2/dpo_student_infer_only.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ def read_json_field(filename):
data = json.load(file)
output = []
for item in data:
instruction = item["instruction"]
output = item["output"]
output.append({"prompt": instruction, "chosen": output})
output.append({"prompt": item["instruction"], "chosen": item["output"]})
Comment on lines 33 to +35

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a list comprehension is more idiomatic, concise, and efficient in Python compared to initializing an empty list and appending to it in a loop.

Suggested change
output = []
for item in data:
instruction = item["instruction"]
output = item["output"]
output.append({"prompt": instruction, "chosen": output})
output.append({"prompt": item["instruction"], "chosen": item["output"]})
output = [
{"prompt": item["instruction"], "chosen": item["output"]}
for item in data
]

return output
except FileNotFoundError:
logging.error("The file was not found.")
Expand Down