mfgrdfile: add version and crs properties#2711
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2711 +/- ##
===========================================
+ Coverage 55.5% 72.5% +17.0%
===========================================
Files 644 677 +33
Lines 124135 132721 +8586
===========================================
+ Hits 68947 96354 +27407
+ Misses 55188 36367 -18821
🚀 New features to boost your workflow:
|
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GRB v2 binary grid file support (CRS, version, export)
versionandcrsproperties toMfGrdFilefor reading GRB v1 and v2 filesMfGrdFile.export()to write GRB v2 files with embedded CRS; auto-detects output version based on CRS presence; supportsint,str, andpyproj.CRSinputs via_crs_to_string()Fixed issues:
write_line()was not placing\nat the fixed position 49; Fortran readers parse header and definition lines as fixed-length text records and require the newline exactly at the end positionorder="F"(column-major); multi-dimensional arrays in_datadict(e.g. DISV BOTM, reshaped to(nlay, ncpl)) were written cell-major instead of layer-major; fixed toorder="C"to match MF6 on-disk layoutexport()hardcoded per-grid-type variable lists with manually specified shapes; replaced with shapes derived from_recorddict(parsed source file structure), fixing incorrect DIS TOP array shape