Bump Typescript to 6 - #252
Open
mt-btanner wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Typescript to 6 to resolve some peer dependency warnings (
ts-jest) which then required bumping related packages. This moves us to the latest versions of those packages (or the latest non-Go version in Typescript's case).Test changes are mostly straightforward exchanges of a deprecated matcher for the new one, but there is one change which required a change to application code.
In the latest JSDom version you can't modify
windowanymore, so tests which relied on spying on that don't work. To avoid this I created ahasWindowhelper (which can be spied on) and replaced the!windowchecks with it.