[LON-427] Drop snake-case package - #253
Merged
Merged
Conversation
|
Code looks good, and it might just be my unfamiliarity with the codebase but I don't see a test for the snake case functionality. |
Contributor
Author
Yeah there's no explicit test but this one covers it implicitly since the inputs are camelCase and the expectation is I also wasn't too worried about it in general since the logic is literally copy/pasted from Vault/Guest Service where it's extensively tested/hasn't caused issues yet, but I can also copy the tests across if you'd prefer. |
mt-btanner
force-pushed
the
lon-427-drop-snake-case
branch
from
July 30, 2026 05:48
22cfd24 to
9f08ef2
Compare
mt-mwalston
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have logic for this (and more complex usecases) in other projects; this PR introduces the simplest possible version here to allow dropping a dependency.
I also update the
/sampledirectoryyarn.lockto reflect recently removed dependencies by runningyarn install.