[LON-427] Drop create-hash - #255
Open
mt-btanner wants to merge 8 commits into
Open
Conversation
mt-mwalston
previously approved these changes
Jul 30, 2026
mt-btanner
force-pushed
the
lon-427-drop-create-hash
branch
from
July 30, 2026 05:46
b3d0485 to
bfe1f0c
Compare
Contributor
Author
|
@mt-mwalston Had to rebase to resolve some conflicts, can you reapprove? |
mt-mwalston
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one function somehow managed to introduce 2 runtime dependencies for things which can be vendored in a single line or replaced with native APIs.
create-hashThis can be replaced with the
crypto.subtleAPI, available in browser and Node environments. I also preserved the behaviour of dropping the trailing "=".The implementation is copied from Google's here
url-safe-base64We used this exclusively to make the base64 hash URL-safe, which is a one-line method from the package. I inlined it as a helper instead.
uuid?I'm not entirely sure how this ever worked, considering
uuidas a package was never in runtime dependencies and@types/uuidwas only in devDependencies. As you can see in the diff from its removal,uuidwasn't brought intoyarn.lockas a dependency of the@typespackage either.Regardless, it's now replaced with
window.crypto.randomUUID(), available in both browser and Node environments.