Skip to content

Do not invoke ctest when BUILD_TESTING=OFF#1201

Merged
eramongodb merged 2 commits into
mongodb:masterfrom
eramongodb:crypt-build_all-tests
Jul 13, 2026
Merged

Do not invoke ctest when BUILD_TESTING=OFF#1201
eramongodb merged 2 commits into
mongodb:masterfrom
eramongodb:crypt-build_all-tests

Conversation

@eramongodb

Copy link
Copy Markdown
Contributor

Resolve the following error when libmongocrypt is built by the C Driver with CMake 4.4.0 and BUILD_TESTING=OFF:

*********************************
No test configuration file found!
*********************************
Usage
  ctest [options]

Per CMake 4.4.0 release notes:

ctest now exits with non-zero if invoked with no arguments and no test input file exists.

@eramongodb
eramongodb requested a review from kevinAlbs July 13, 2026 14:47
@eramongodb eramongodb self-assigned this Jul 13, 2026
@eramongodb
eramongodb requested a review from a team as a code owner July 13, 2026 14:47

@kevinAlbs kevinAlbs left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eramongodb

Copy link
Copy Markdown
Contributor Author

Subtle bugfix: is_true expands the given argument as a variable. Need to pass the name of the boolean variable, not the value.

@eramongodb
eramongodb merged commit 63fee9f into mongodb:master Jul 13, 2026
3 of 4 checks passed
@eramongodb
eramongodb deleted the crypt-build_all-tests branch July 13, 2026 14:59
mdb-ad pushed a commit to mdb-ad/libmongocrypt that referenced this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants