moq-lite-05: fill Security Considerations and fix reference/changelog nits#46
Conversation
There was a problem hiding this comment.
Sorry @kixelated, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
… nits
Pre-publish review cleanup for moq-lite-05:
- Replace the Security Considerations TODO with sections on bandwidth
probing/amplification, session redirection, routing-metadata privacy,
resource exhaustion, datagram injection, and opaque payloads. Add
explicit {#announce-ok}/{#announce-request} anchors for the new
cross-references.
- Fix RFC9002 double-declaration (inline {{!RFC9002}} -> [RFC9002]) to
clear the kramdown-rfc build warning.
- Add the missing SETUP `Path` parameter bullet to the moq-lite-05
changelog.
- Note that SUBSCRIBE_OK/SUBSCRIBE_END/SUBSCRIBE_DROP group sequences are
plain absolute values, not the `absolute + 1` form used by Group
Start/End in SUBSCRIBE.
- Correct the moq-lite-04 changelog rename bullet (ANNOUNCE_PLEASE ->
ANNOUNCE_SUBSCRIBE; the rename to ANNOUNCE_REQUEST happened in -05).
- Measure timestamp age against the latest group that has at least one
frame, so an empty latest group no longer makes the measure
uncomputable for the whole track.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2eb7cef to
6fc0d58
Compare
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pre-publish review pass over
draft-lcurley-moq-lite.mdahead of taggingmoq-lite-05. No wire-format changes; this is documentation correctness, one clarified semantic edge case, and changelog/reference hygiene. Builds clean (make draft-lcurley-moq-lite.txt) with no kramdown-rfc warnings.What changed
TODOwith sections covering bandwidth probing/amplification (theIncreaseProbe level is bounded by the congestion window), session redirection (GOAWAY URI validation), routing-metadata privacy (Hop ID0), resource exhaustion, datagram injection, and opaque payloads. Added explicit{#announce-ok}/{#announce-request}heading anchors so the new cross-references resolve.{{!RFC9002}}to[RFC9002]since it's already declared in the YAMLnormative:block; clears the double-declaration build warning.moq-lite-05) — added the missingPathSETUP parameter bullet.moq-lite-04) — corrected the rename bullet toANNOUNCE_PLEASE -> ANNOUNCE_SUBSCRIBE(the rename toANNOUNCE_REQUESTactually happened in-05).SUBSCRIBE_OK/SUBSCRIBE_END/SUBSCRIBE_DROPcarry plain absolute group sequences, not theabsolute + 1form used byGroup Start/Group EndinSUBSCRIBE, and tightened theSUBSCRIBE_OKcomparison prose to decode-before-comparing.Reviewer notes
🤖 Generated with Claude Code